-
Notifications
You must be signed in to change notification settings - Fork 4
Add a contribution ladder to gittuf #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4d5ca6a
to
c0417c6
Compare
Signed-off-by: Pat Zielinski <[email protected]>
c0417c6
to
adccaa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions
- Reviewed at least 5 substantial PRs to the codebase | ||
- Reviewed or got at least 10 PRs merged to the codebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want literal limits or should this be more like my suggested text:
- Reviewed at least 5 substantial PRs to the codebase | |
- Reviewed or got at least 10 PRs merged to the codebase | |
- Provided substantial improvements to the codebase (e.g., adding 5 substantial PRs to the codebase) | |
- Helped to review other submissions to the codebase (e.g., reviewed 10 PRs that were merged to the codebase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think both of the above lines in your PR should not start with Reviewed. Do you mean authored, etc.?
This PR adds a contribution ladder to gittuf, formalizing how community members may advance to roles that are more involved with the gittuf project.
Closes #10.