gh-770: Default to numpy for redshift_grid and fixed_zbins if no xp is provided #771
Conversation
connoraird
changed the title
connoraird
changed the title
|
Thanks for looking into this! How about we create a |
Sounds like a great idea |
connoraird
force-pushed
the
connor/issue-770
branch
from
28e2f5d to
5aeec79
Compare
connoraird
force-pushed
the
connor/issue-770
branch
from
5aeec79 to
604c498
Compare
glass/_array_api_utils.py
Outdated
| def default_xp() -> ModuleType: | ||
| """Returns the library backend we default to if none is specified by the user.""" | ||
| warnings.warn( | ||
| f"No array library has been provided for call to {inspect.stack()[1].function}", |
There was a problem hiding this comment.
¯\_(ツ)_/¯
Would you rather leave out the calling function name?
There was a problem hiding this comment.
Maybe? When we call import_numpy elsewhere, the CompatibleBackendNotFoundError doesn't say where the backend is missing
There was a problem hiding this comment.
I think it's fine for users to use GLASS as a CPU code so I wouldn't warn on default_xp(), at least for the time being.
| # check num input | ||
|
|
||
| num = 5 | ||
| with pytest.warns( |
There was a problem hiding this comment.
These aren't relevant any more, see test failures
Description
Removed requirement for xp to be passed into redshift_grid and fixed_zbins. Now the default library used will be numpy.
Fixes: #770
Changelog entry
Fixed: redshift_grid and fixed_zbins no longer rely on xp being passed. Now defaults to numpy.
Checks