Initial support for Zarr v3 #290
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-moore
reviewed
Sep 23, 2025
| } | ||
|
|
||
| void checkMultiscale(Map<String, Object> multiscale, String name) { | ||
| assertEquals(getNGFFVersion(), multiscale.get("version")); |
There was a problem hiding this comment.
I'm not sure if this multiscale is zarr v3 but in OME-Zarr v0.5, the version is not under multiscale any more but under "attributes": {"ome": {"version": "0.5", "multiscales": {...}
There was a problem hiding this comment.
Good point, thanks @will-moore. I'll need to update that in both the conversion and the test then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft to show some initial progress, but there are still a few things to do here before this is ready for full review:
--shard-width,--shard-height,--shard-depthto match chunk options?)A simple test of
bin/bioformats2raw --v3 test.fake test-v3.zarror similar should work though, and v2 output should be unaffected as indicated by passing tests.