Remove template selection for simplified interface profiles

[cconard96]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.

Description

Fixes #21378
Since Forms have completely replaced direct tickets for simplified interface users, there seems to be no need to have the default template option in the profile form.

[orthagh]

Ok for that, it'll be much clearer

[AdrienClairembault]

It depends how we interpret this configuration:

Should it rely on this profile setting?

[cconard96]

Honestly, I am still confused about the place templates have now in GLPI 11. Even if it was from a PR I did (3 and a half years ago at the start of GLPI 11 dev for a client-sponsored development), the fact that templates get applied when a ticket is created and stay associated with that template makes for some odd behaviors and I don't know what should be considered intended or not.

[AdrienClairembault]

The form feature call CommonITILObject::getITILTemplateToUse().

If you can double check to make sure this method do not rely on the setting you deleted then the change is OK for me.

(But if you deleted it from the UI, maybe there is also something to clean up in the database?)

[cconard96]

The form feature call CommonITILObject::getITILTemplateToUse().

How does it use that information? Templates are/were just a UI feature and it seems like Forms completely replace their functionality in this context.

(But if you deleted it from the UI, maybe there is also something to clean up in the database?)

I'd rather not delete data from the DB at all unless it is invalid and would cause bugs. When other fields that exist only for standard interface profiles are set, they are not deleted when switching it to simplified interface.

[AdrienClairembault]

How does it use that information? Templates are/were just a UI feature and it seems like Forms completely replace their functionality in this context.

It applies the predefined fields of the templates into the ticket input.

I'd rather not delete data from the DB at all unless it is invalid and would cause bugs. When other fields that exist only for standard interface profiles are set, they are not deleted when switching it to simplified interface.

Ok, I didn't see that the field is still used for central profiles.

---

The profile value does seems to be used by CommonITILObject::getITILTemplateToUse():

So IMO it should still be configurable for self service profiles (and change and problems templates should likely be configurable as well since we can create them with forms).