Check if ONLY_FULL_GROUP_BY is disabled #22005
Draft
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
trasher
force-pushed
the
check/ONLY_FULL_GROUP_BY
branch
from
21a4113 to
03a46d2
Compare
cedric-anne
reviewed
Nov 20, 2025
| // force mysqlnd to return int and float types correctly (not as strings) | ||
| $this->dbh->options(MYSQLI_OPT_INT_AND_FLOAT_NATIVE, 1); | ||
|
|
||
| $this->dbh->query("SET SESSION sql_mode = (SELECT REPLACE(@@sql_mode, 'ONLY_FULL_GROUP_BY', ''))"); |
Member
There was a problem hiding this comment.
Maybe this would be sufficient. If it is possible, it would be better to not add an extra query on every GLPI request.
Suggested change
| $this->dbh->query("SET SESSION sql_mode = (SELECT REPLACE(@@sql_mode, 'ONLY_FULL_GROUP_BY', ''))"); | |
| if ($this->dbh->query("SET SESSION sql_mode = (SELECT REPLACE(@@sql_mode, 'ONLY_FULL_GROUP_BY', ''))") === false) { | |
| throw new RuntimeException('Unable to disable the ONLY_FULL_GROUP_BY SQL mode.'); | |
| } |
Contributor
Author
There was a problem hiding this comment.
@mo-wcma please try this alternative as well.
Contributor
Author
There was a problem hiding this comment.
(indeed it would be better to have only 1 query)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.