Refactoring of diff algorithm and utilities #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementations are instantiated they do not care what the type of diffed element will be.
This typeclass intends to avoid conversion to an `IndexedSeq` object, for classes that are not. It exposes the required API so that the Lcs algorithms work. In particular, this avoids converting a `String` into an `IndexedSeq`.
By default two elements of the sequences to diff are considered equivalent if they are equal in the sense of the `equals` method. However, by providing a different `Equiv` instance, you may change the way elements are considered equal.
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 38.63% 40.31% +1.68%
==========================================
Files 43 46 +3
Lines 1522 1580 +58
Branches 167 171 +4
==========================================
+ Hits 588 637 +49
- Misses 934 943 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.