Blocks/Analog : port Frequency/Phase Mod + AM/FM demod blocks to GR‑4(Retargeted) #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts) Signed-off-by: KrxGu <[email protected]>
* adds processOne helpers, bulk publishing fix * updates block-local CMake to relax warning flags * adds qa_Analog Boost.UT test suite Signed-off-by: KrxGu <[email protected]>
Signed-off-by: KrxGu <[email protected]>
Signed-off-by: KrxGu <[email protected]>
This adds working GR‑4 replacements for the classic GR‑3.x • frequency_modulator_fc → FrequencyMod.hpp • phase_modulator_fc → PhaseModulator.hpp • quadrature_demod_cf → QuadratureDemod.hpp • fmdet_cf → FmDet.hpp • analog_am_demod_cf (new) → AmDemod.hpp Each block comes with a Boost.UT unit‑test and the analog/test CMake files are updated accordingly. Signed-off-by: KrxGu <[email protected]>
These files belong to an earlier helpers‑merge and should not be part of the AM/FM/PM block port. Also remove their CMake targets. Signed-off-by: KrxGu <[email protected]>
* New headers: Agc.hpp, Agc2.hpp * Added tests: qa_Agc.cpp, qa_Agc2.cpp * Updated CMakeLists for library and test targets Signed-off-by: KrxGu <[email protected]>
Fix library linking and warning suppressions to resolve CI build failures. Signed-off-by: Krish Gupta <[email protected]>
KrxGu
force-pushed
the
port-analog-block
branch
from
1209224 to
5345c47
Compare
Replace std::fabs with std::abs for complex number magnitude calculation in Agc and Agc2 blocks. std::fabs is not overloaded for complex types, causing CI compilation failures in clang builds. Fixes compilation errors in generated AGC blocks when used with std::complex<float>. Signed-off-by: KrxGu <[email protected]>
- Add explicit type aliases for AgcCC, AgcFF, Agc2CC, Agc2FF - Move type aliases outside test functions for better CI compatibility - Fix template resolution issues in clang/emcc CI environments - Ensure proper namespace resolution for gr::blocks::analog::Agc types Signed-off-by: Krish Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analog‑blocks port – status snapshot
(tick = already landed in this PR, blank = left for follow‑up)
Tests & CMake targets for every ☑️ header are included; commits are DCO‑signed.