Skip to content

Conversation

gufm23
Copy link

@gufm23 gufm23 commented Jul 31, 2025

I needed to use this module with GRC 3.10, so I changed some code to be compatible with the newer version. It built and workded, but I couldn't port the tests. So it built, but without tests.

@dkozel
Copy link

dkozel commented Jul 31, 2025

Hi @gufm23 Thank you for porting the module and posting the PR. I'll do a test build and let you know my feedback.

Could you please amend the PR to remove the .pyc files from Doxygen?

@gufm23
Copy link
Author

gufm23 commented Aug 1, 2025

Hi @dkozel I amended the PR as you said. I just checked in my GRC and I can't see the block's documentations. I don't know if it was working before in version 3.8 or it is due to my port that it broke, I'm not really a GNU Radio expert.

@alekhgupta1441
Copy link
Collaborator

Thanks @gufm23 for the PR contribution. This is definitely a long pending update needed in gr-dpd, I will defer to @dkozel for the detailed review.

I don't know if it was working before in version 3.8 or it is due to my port that it broke, I'm not really a GNU Radio expert.

I remember dpd blocks worked fine with the GR-3.8, are you able to get some of the example workflows running: https://github.com/gnuradio/gr-dpd/tree/1f2cff3179db09152d86b6209c5b66b06c948f20/examples

@gufm23
Copy link
Author

gufm23 commented Aug 2, 2025

Hi @alekhgupta1441! The example flowcharts worked.

About not working I mean the block's documentation. And I dont't really know if it is not working or it is how it is supposed to be. Because I expected to see a documentation here when opening the documentation tab in the block's properties, but what I see is just this text: Out of Tree block. (I'm not at the computer where I can reproduce it, so this is just an example from another block)

image

But as I said, I don't know if this is the expected behaviour.

@alekhgupta1441
Copy link
Collaborator

Because I expected to see a documentation here when opening the documentation tab in the block's properties, but what I see is just this text: Out of Tree block.

Yes, ideally block's documentation from code should be visible in GRC-UI correctly from what I remember till 3.8. But I am not sure if anything changed in 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants