-
Notifications
You must be signed in to change notification settings - Fork 109
Improvements to existing NSDataLink code #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Looking at the diffs, it seems to me that the changes are almost all cosmetic (improving ivar names and changing whitespace).
I generally try to do cosmetic stuff separately first. |
They are at this point. My original intention with this PR was to make the class actually work. I implemented what is there a long time ago, but got stuck on how to monitor changes to a file without polling it (which is terribly inefficient) so, I wanted to come back to it and see if I could find a way to make it functional. Sometimes I do the "cosmetic" stuff while I am thinking as it helps me think more cleanly. I don't know if that makes sense, but it's my process. ;) Point taken. It would be understandable from the reviewer's point of view. When I did this I hadn't considered that. |
The test for this is here https://github.com/gcasa/NSDataLink_test I will incorporate this into the test suite after some refinement. |
@fredkiefer or @rfm please review, I believe it should work. I am writing tests for it now. Unfortunately it can only be tested on OPENSTEP4.2. I will attach any docs I have on that as well. |
These changes will implement the rest of NSDataLink/NSDataLinkManager. This class was not often used, but is relatively easy to implement. This class was rarely used, but should be easy to finish.
The test is here:
https://github.com/gcasa/NSDataLink_test