Skip to content

Exploit SetIdStringer to set id string representation in String method #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2-unstable
Choose a base branch
from
+15 −3
Open

Exploit SetIdStringer to set id string representation in String method #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions bson/bson.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,10 +257,22 @@ func NewObjectIdWithTime(t time.Time) ObjectId {
return ObjectId(string(b[:]))
}

// objectIdStringer contains the function used in String() method of ObjectId type.
// It can be set by user through the exported SetIdStringer function.
var objectIdStringer = func(id ObjectId) string {
return fmt.Sprintf(`ObjectIdHex("%x")`, string(id)) // id default stringer
}

// SetIdStringer defines how the string representation of ObjectId type should be in its String() method.
func SetIdStringer(f func(ObjectId) string) {
objectIdStringer = f
}

// String returns a hex string representation of the id.
// Example: ObjectIdHex("4d88e15b60f486e428412dc9").
// The default representation looks like: ObjectIdHex("4d88e15b60f486e428412dc9"),
// which can be changed/defined through the function argument provided for SetIdStringer.
func (id ObjectId) String() string {
return fmt.Sprintf(`ObjectIdHex("%x")`, string(id))
return objectIdStringer(id)
}

// Hex returns a hex representation of the ObjectId.
Expand All @@ -279,7 +291,7 @@ var nullBytes = []byte("null")
func (id *ObjectId) UnmarshalJSON(data []byte) error {
if len(data) > 0 && (data[0] == '{' || data[0] == 'O') {
var v struct {
Id json.RawMessage `json:"$oid"`
Id json.RawMessage `json:"$oid"`
Func struct {
Id json.RawMessage
} `json:"$oidFunc"`
Expand Down