Unpatched wine fix #229
Unpatched wine fix #229
Conversation
If info procmap fails, we will try to find process by name. Prevents the xlcore process from hanging with unpatched wine or patched valve wine.
|
Do we officially offer any wine that can run into these problems? Not that it's a blocker for merging, just curious to if this is something that can impact anything official |
|
The only wine I know to be affected is wine-ge-xiv, with amd graphics. May also only apply to mesa 23.x and earlier, but Ive noticed regressions happen fairly often in the amd drivers. And of course unpatched wine will fail the pid check, whic this patch also addresses. |
|
This seems fine to include, given we have a rising number of users who are trying to use unofficial or unsupported wine builds (including system wine, like the Cachy users). Do we still need it for newer wine builds though? Or does this only affect a certain version range? I'm still on board with including it to reduce any potential troubleshooting efforts. |
If running patched valve-wine, the dalamud injector may occasionally spit out an error about not finding a video device before spitting out the expeced winePid JSON. This will prevent the process ID from being found. Added a loop to try checking a few more times before failing.
If
info procmapfails (due to wine being unpatched), we will try to find the process by name. This prevents the xlcore process from hanging with unpatched wine. This is currently not a big issue since current unpatched wine simply crashes dalamud, but it may become relevant when the debug helper code gets fixed.This is all ported over from the previous compatibility-rework-2.