Fix stablewine prefix error #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiichi001
approved these changes
Jun 28, 2025
|
this is good for now, in the future I want to remake the prefix as the lsteamclient stuff wont be on the beta branch forever |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from Beta to Stable or Legacy (or custom wine without lsteamclient), the wine prefix will be broken. This is because the lsteamclient.dll in system32 will not have any backing files in the lib/wine/x86_64-unix or lib/wine/x86_64-windows folders, so when Dalamud tries to load it, it crashes.
This patch checks to see if we're not using Beta wine or are using custom wine, and then deletes the lsteamclient.dll if so. It does this before ensuring the prefix, so if the custom wine does contain lsteamclient, it will regenerate the lsteamclient.dll when ensuring the prefix.
This will fix Issue #251, for example.