Skip to content

Minimize CI burden by commenting out parts of the matrix #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minimize CI burden by commenting out parts of the matrix #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 28 additions & 10 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,40 @@ jobs:
target:
[
{ platform: linux, arch: x86_64, os: ubuntu-22.04 },
{ platform: linux, arch: x86_32, os: ubuntu-22.04 },
{ platform: linux, arch: arm64, os: ubuntu-22.04-arm },
{ platform: linux, arch: arm32, os: ubuntu-22.04-arm },
#{ platform: linux, arch: x86_32, os: ubuntu-22.04 },
#{ platform: linux, arch: arm64, os: ubuntu-22.04-arm },
#{ platform: linux, arch: arm32, os: ubuntu-22.04-arm },
{ platform: windows, arch: x86_64, os: windows-latest },
{ platform: windows, arch: x86_32, os: windows-latest },
{ platform: windows, arch: arm64, os: windows-latest },
#{ platform: windows, arch: x86_32, os: windows-latest },
#{ platform: windows, arch: arm64, os: windows-latest },
{ platform: macos, arch: universal, os: macos-latest },
{ platform: android, arch: x86_64, os: ubuntu-22.04 },
{ platform: android, arch: x86_32, os: ubuntu-22.04 },
{ platform: android, arch: arm64, os: ubuntu-22.04 },
{ platform: android, arch: arm32, os: ubuntu-22.04 },
#{ platform: android, arch: x86_32, os: ubuntu-22.04 },
#{ platform: android, arch: arm64, os: ubuntu-22.04 },
#{ platform: android, arch: arm32, os: ubuntu-22.04 },
{ platform: ios, arch: arm64, os: macos-latest },
{ platform: web, arch: wasm32, os: ubuntu-22.04 },
#{ platform: web, arch: wasm32, os: ubuntu-22.04, threads: no},
]
target-type: [template_debug, template_release]
float-precision: [single, double]
target-type:
[
template_debug,
template_release
]
float-precision:
[
single,
#double
]
include:
- platform: linux
arch: x86_64
os: ubuntu-22.04
float-precision: double
- platform: web
arch: wasm32
os: ubuntu-22.04
threads: no
Comment on lines +44 to +52
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bromeon You mean like this? I took a look at gdext and the docs page you linked

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, does it work as expected?

Small side note, the [ ] syntax across multiple lines is a bit unusual in YAML, although allowed. Typically lists are - prefixed like here 🙂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure :/ the action on GitHub doesn't run (and doesn't show any debug info either). I tried to run the action locally but I can't run everything there with Docker either 😅

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's here, in the Actions tab of the repo 🙂

Build GDExtension
Error when evaluating 'runs-on' for job 'build'. .github/workflows/builds.yml (Line: 54, Col: 14): Unexpected value ''

The problem is that target is nested (itself a list of objects containing platform/arch/os), but you only refer to its sub-keys.

The include however needs to refer to paths from the top level, like target-type. I'm not sure how the exact syntax would work for a nested property, maybe

    include:
      - target:
            platform: linux
            arch: x86_64
            os: ubuntu-22.04
        float-precision: double

GitHub Actions are always trial&error, you might need to experiment a bit (or ask an AI, which itself can be trial&error) 😬 But it's also possible that this isn't supported, and would need flat keys.


runs-on: ${{ matrix.target.os }}
steps:
Expand Down