cmd/deadcode: suppress marker interface method reporting #598

FolkLoreee · 2025-10-09T03:55:36Z

The deadcode tool now suppresses marker interface methods
from the default output, as these are typically intentional interface
implementations rather than dead code.
Marker interface methods are unexported methods that: implement
a top-level interface and have no parameters, results, and function body.

Add Marker field to jsonFunction struct to indicate when a function
is a marker interface method, allowing users to filter or identify
these methods in custom format templates.

Fixes golang/go#75628

FolkLoreee · 2025-10-09T04:01:40Z

Note: cmd/deadcode/testdata/issue65915.txtar was modified so that deadcode does not erroneously flag the methods as marker methods.

This should still maintain the same behavior expectation as reported in golang/go#65915

gopherbot · 2025-10-09T04:02:13Z

This PR (HEAD: bda2c6d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/710435.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

The deadcode tool now suppresses marker interface methods by default, as these are typically intentional interface implementations rather than dead code. Users can include them in reports using the new -marker flag. Also: in go/ssa/ssautil, Add IsMarkerMethod helper function to identify marker interface methods based on their properties. The function checks that a function: - is unexported - has no parameters beyond the receiver - has no results - has an empty body. Add Marker field to jsonFunction struct to indicate when a function is a marker interface method, allowing users to filter or identify these methods in using the -f template flag. Fixes golang/go#75628

gopherbot · 2025-10-09T04:09:24Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-09T04:16:35Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-09T04:23:44Z

This PR (HEAD: 033c02d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/710435.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-09T13:51:23Z

Message from Alan Donovan:

Patch Set 3:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

…t of ssautil, cleanup on docs

gopherbot · 2025-10-11T02:37:26Z

This PR (HEAD: ae0fc95) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/710435.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-15T14:30:24Z

This PR (HEAD: 75cc227) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/710435.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-15T14:55:26Z

Message from Filbert Cia:

Patch Set 6:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-15T19:34:25Z

Message from Alan Donovan:

Patch Set 6:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

…it, makes isMarkerMethod more concise

gopherbot · 2025-10-21T15:55:22Z

This PR (HEAD: 109b3ac) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/710435.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-21T16:14:32Z

Message from Filbert Cia:

Patch Set 6:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T17:55:14Z

Message from Alan Donovan:

Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:04:22Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-21T17:46:41Z","revision":"9cee034a6bec969697c48070d3db4ef5022e231b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:13:34Z

Message from Alan Donovan:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:13:34Z

Message from Go LUCI:

Patch Set 7:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-go1.25-darwin-amd64_14 has failed with summary (view all results):

go on release-branch.go1.25 (commit f6db735) / tools on master (change 710435)

To reproduce, try gomote repro 8700379229683161361.

Additional links for debugging:

test golang.org/x/tools module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:13:35Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:40:13Z

Message from Alan Donovan:

Patch Set 8: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:40:14Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-21T18:27:52Z","revision":"152c4dcab6d2503953fa9c524b5eb324dd33cb74"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:58:25Z

Message from Alan Donovan:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:58:26Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64-race has failed with summary (view all results):

go on master (commit 8f74f9d) / tools on master (change 710435)

To reproduce, try gomote repro 8700376641206894337.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:58:27Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T18:58:27Z

Message from Alan Donovan:

Patch Set 8: Commit-Queue+1 TryBot-Bypass+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T19:07:36Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-21T18:47:27Z","revision":"152c4dcab6d2503953fa9c524b5eb324dd33cb74"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T19:07:37Z

Message from Alan Donovan:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T19:07:38Z

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64-race has failed with summary (view all results):

go on master (commit c9c78c0) / tools on master (change 710435)

To reproduce, try gomote repro 8700375401891847585.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/710435.
After addressing review feedback, remember to publish your drafts!

The deadcode tool now suppresses marker interface methods from the default output, as these are typically intentional interface implementations rather than dead code. Marker interface methods are unexported methods that: implement a top-level interface and have no parameters, results, and function body. Add Marker field to jsonFunction struct to indicate when a function is a marker interface method, allowing users to filter or identify these methods in custom format templates. Fixes golang/go#75628 Change-Id: I8271fad800717a96ead18ba9b0f3c4e7b23f864a GitHub-Last-Rev: 109b3ac GitHub-Pull-Request: #598 Reviewed-on: https://go-review.googlesource.com/c/tools/+/710435 Auto-Submit: Alan Donovan <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Alan Donovan <[email protected]> TryBot-Bypass: Alan Donovan <[email protected]>

gopherbot · 2025-10-21T20:01:28Z

This PR is being closed because golang.org/cl/710435 has been merged.

FolkLoreee force-pushed the deadcode-marker-intf branch from bda2c6d to 033c02d Compare October 9, 2025 04:17

feat: add check by interface implementation, move marker functions ou…

ae0fc95

…t of ssautil, cleanup on docs

fix: remove -marker flag from deadcode

75cc227

FolkLoreee changed the title ~~cmd/deadcode: suppress marker interface method reporting by default~~ cmd/deadcode: suppress marker interface method reporting Oct 15, 2025

cleanup: combines collecting interface into the existing packages.Vis…

109b3ac

…it, makes isMarkerMethod more concise

gopherbot closed this Oct 21, 2025

cmd/deadcode: suppress marker interface method reporting #598

cmd/deadcode: suppress marker interface method reporting #598

Conversation

FolkLoreee commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FolkLoreee commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 9, 2025

Uh oh!

gopherbot commented Oct 11, 2025

Uh oh!

gopherbot commented Oct 15, 2025

Uh oh!

gopherbot commented Oct 15, 2025

Uh oh!

gopherbot commented Oct 15, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

gopherbot commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

FolkLoreee commented Oct 9, 2025 •

edited

Loading