Skip to content

feat: add command to modify granted always allow permissions #6902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add command to modify granted always allow permissions #6902

wants to merge 5 commits into from
+2,920 βˆ’6

Conversation

bulkypanda
Copy link
Member

@bulkypanda bulkypanda commented Aug 23, 2025 •
edited
Loading

TLDR

introduces a new command to allow revoking previously always allowed tools

Reviewer Test Plan

always allow a tool and then test /permissions

Testing Matrix

🍏 πŸͺŸ 🐧
npm run ❓ ❓ βœ…
npx ❓ ❓ ❓
Docker ❓ ❓ ❓
Podman ❓ - -
Seatbelt ❓ - -

Linked issues / bugs

@bulkypanda bulkypanda changed the title feat: add command to modify grants always allow permissions feat: add command to modify granted always allow permissions Aug 23, 2025
@Kfcfjkkhg
Copy link

Kfcfjkkhg commented Aug 23, 2025 via email

@bulkypanda bulkypanda added kind/enhancement New feature or request help wanted Extra attention is needed status/in-progress This issue is currently being worked on. area/tools Built-in tools and the MCP ecosystem. community: for-discussion A community PR that warrants discussion before we can decide to accept it. Will reviewed further. labels Aug 23, 2025
@bulkypanda
fix: permissions command now works for memory, shell, and MCP tools
9b7abfa 
- Export MemoryToolInvocation and DiscoveredMCPToolInvocation classes
- Fix PermissionService imports to use proper static method calls
- Replace require() calls with direct class imports for better type safety
@bulkypanda
fix: resolve lint and build errors
c993e70 
- Add default case to switch statement in PermissionService
- Fix React unescaped entities in PermissionsDialog
- Add missing useCallback dependency in slashCommandProcessor
- Fix TypeScript any type usage with ESLint disable
@bulkypanda
enhance: improve permissions dialog UX with individual permission nav…
f5d9312 
…igation

- Add individual permission selection and navigation within groups
- Add ability to reset individual permissions with 'r' key
- Refactor permission reloading into reloadPermissions helper
- Update UI to show focused permission with visual indicator
- Improve keyboard navigation between groups and individual permissions
- Update help text and visual indicators for better UX
@bulkypanda bulkypanda removed help wanted Extra attention is needed community: for-discussion A community PR that warrants discussion before we can decide to accept it. Will reviewed further. labels Aug 23, 2025
@bulkypanda
test: add comprehensive test coverage for permissions system
67ed265 
- Add tests for PermissionService core functionality
- Add tests for permissions command implementation
- Add tests for PermissionsDialog component
- Add tests for usePermissionsCommand hook
- Update existing test files to maintain compatibility
@bulkypanda bulkypanda marked this pull request as ready for review August 24, 2025 00:35
@bulkypanda bulkypanda requested a review from a team as a code owner August 24, 2025 00:35
@bulkypanda bulkypanda removed the status/in-progress This issue is currently being worked on. label Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/tools Built-in tools and the MCP ecosystem. kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Provide a command to reset granular tool permissions Allow me to look at and modify any Always Allow permissions I may have given.
2 participants
@bulkypanda @Kfcfjkkhg