Extract and add CWE IDs from CVE problem-types #4167
Conversation
Closes google#4159 Introduces the attachCWEs function to extract CWE IDs from both CNA and ADP problem-types in CVE5 records and store them in the Vulnerability's DatabaseSpecific field. Also updates the ProblemTypes struct to include a CWEID field for more accurate parsing. - Updated ProblemTypes struct to include `CweID` field to match CVE5 JSON schema. - Updated attachCWEs() function to store both CWE ID and human-readable description.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Thank you for the contribution and the work you put into this PR! It’s awesome to have you contributing.
I’ve left a few inline suggestions. If you could revise based on the comments to reduce the overall complexity, that would be perfect. We look forward to merging your work soon!
|
Updated attachCWEs function per review feedback. Now uses only the CWEID field and removes regex/description parsing. The PR is ready for another review. |
|
Awesome thanks for that improvement! It looks like the tests are failing as they will need to be updated with the additional data. To run the tests to check, use To check for linting errors, run |
…e test returned no issue
|
@jess-lowe made all the necessary changes and also checked that lint and vulnfeed-tests return no error |
|
/gcbrun |
|
Let me know if there's anything else I can contribute to. |
2 participants
Closes #4159
Introduces the attachCWEs
function to extract CWE IDs from both CNA and ADP problem-types in CVE5 records and store them in the Vulnerability's DatabaseSpecific field. Also updates the ProblemTypes struct to include a CWEID field for more accurate parsing.
CweIDfield to match CVE5 JSON schema.