Skip to content

Bump google-auth dep version #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Bump google-auth dep version #2625

wants to merge 3 commits into from

Conversation

razvanphp
Copy link
Contributor

@razvanphp razvanphp commented Sep 3, 2024 •
edited
Loading

@razvanphp razvanphp requested a review from a team as a code owner September 3, 2024 07:34
@bshaffer
Copy link
Contributor

thank you @razvanphp !

Is there a specific reason why this needs to be bumped? I'm happy to do it, but I am curious because we do have --prefer-lowest tests which are passing, so if there's a compatibility error with a previous version, I would like to check why we aren't catching it.

@razvanphp
Copy link
Contributor Author

Ah, I see your point. The reason is so that we can use the features included in those new versions without risking not having them.

We have a dependancy on this repo only, not on the auth package. Maybe we can add this as explicit in our composer.json instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@razvanphp @bshaffer