Skip to content

chore: fix boolean comparison #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

chore: fix boolean comparison #1793

wants to merge 4 commits into from

Conversation

parthea
Copy link
Contributor

@parthea parthea commented May 6, 2022

Fixes warning from flake8 . --select E712

(py39) partheniou@partheniou-vm-2:~/git/google-api-python-client$ flake8 . --select E712
./scripts/buildprbody.py:83:40: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
./scripts/changesummary.py:211:46: E712 comparison to True should be 'if cond is True:' or 'if cond:'
./scripts/changesummary.py:223:50: E712 comparison to True should be 'if cond is True:' or 'if cond:'

@parthea parthea requested a review from a team as a code owner May 6, 2022 15:36
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 6, 2022
@parthea parthea marked this pull request as draft January 8, 2024 17:38
msbatin

This comment was marked as resolved.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchudnov-g vchudnov-g vchudnov-g approved these changes

+1 more reviewer

@msbatin msbatin msbatin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthea @vchudnov-g @msbatin