Skip to content

Conversation

@shubham-up-47
Copy link
Contributor

@shubham-up-47 shubham-up-47 commented Jul 29, 2025

Adding logging decorator for object_descriptor_connection which creates logical logs for the Read() operations created by the application (#15141).

Currently this pattern is followed for otel tracing,

  • connection_tracing.cc
  • object_descriptor_connection_tracing.cc
  • object_descriptor_reader_tracing.cc

Following the same pattern for creating the logging decorator,

  • connection_logging.cc
  • object_descriptor_connection_logging.cc
  • reader_connection_logging.cc

This change is Reviewable

@shubham-up-47 shubham-up-47 requested review from a team as code owners July 29, 2025 08:46
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 29, 2025
@shubham-up-47 shubham-up-47 marked this pull request as draft July 29, 2025 08:46
@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 99.41634% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.03%. Comparing base (9304a3e) to head (32d6e13).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/storage/async/client_test.cc 96.72% 2 Missing ⚠️
...cloud/storage/internal/async/connection_logging.cc 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15331      +/-   ##
==========================================
+ Coverage   93.02%   93.03%   +0.01%     
==========================================
  Files        2403     2409       +6     
  Lines      219441   219955     +514     
==========================================
+ Hits       204139   204645     +506     
- Misses      15302    15310       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shubham-up-47 shubham-up-47 marked this pull request as ready for review August 4, 2025 12:58
@shubham-up-47
Copy link
Contributor Author

/gcbrun

@bajajneha27
Copy link
Contributor

@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR?

@shubham-up-47
Copy link
Contributor Author

/gcbrun

1 similar comment
@shubham-up-47
Copy link
Contributor Author

/gcbrun

@shubham-up-47
Copy link
Contributor Author

@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants