-
Notifications
You must be signed in to change notification settings - Fork 430
feat(storage): adding logging decorator for object_descriptor_connection #15331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(storage): adding logging decorator for object_descriptor_connection #15331
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15331 +/- ##
==========================================
+ Coverage 93.02% 93.03% +0.01%
==========================================
Files 2403 2409 +6
Lines 219441 219955 +514
==========================================
+ Hits 204139 204645 +506
- Misses 15302 15310 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/gcbrun |
|
@shubham-up-47 can you please look at the CI failures before I could start reviewing this PR? |
|
/gcbrun |
1 similar comment
|
/gcbrun |
Done. |
Adding logging decorator for object_descriptor_connection which creates logical logs for the Read() operations created by the application (#15141).
Currently this pattern is followed for otel tracing,
Following the same pattern for creating the logging decorator,
This change is