Skip to content

Conversation

jhambleton
Copy link
Contributor

@jhambleton jhambleton commented Mar 26, 2024

adding capabilities to replication library to control the shape of data as it is replicated to bigtable. the controls are disabled by default, and when enabled, allow users to filter rows and cells which may block replication. The configurations have unit tests as well have been run through a series of tests for a live deployment.

@jhambleton jhambleton requested a review from a team as a code owner March 26, 2024 21:19
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Mar 26, 2024
Assert.assertEquals(false, logAndSkipIncompatibleRowMutationsDoesNotExceedEqual);
Assert.assertEquals(true, logAndSkipIncompatibleRowMutationsExceeds);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test that validates that ReplicationTask does indeed use the results of the VerifyRowMutationThresholds.

I think we should make VerifyRowMutationThresholds private and test that the task failed or succeeded and verify that the appropriate metrics were incremented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants