Skip to content

chore: revert previous node-version template changes in ci.yaml #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: revert previous node-version template changes in ci.yaml #2632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
527f99f
chore: revert previous node-version template changes in ci.yaml
gcf-owl-bot[bot] Aug 15, 2025
3ff1783
Merge branch 'main' into owl-bot-update-lock-b612d739b0533e56ba174526…
ddelgrosso1 Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
matrix:
node: [14, 16, 18]
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
Expand All @@ -26,10 +26,24 @@
- run: npm test
env:
MOCHA_THROW_DEPRECATION: false
test-script:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 18
- run: node --version
- run: npm install --engine-strict
working-directory: .github/scripts
- run: npm test
working-directory: .github/scripts
env:
MOCHA_THROW_DEPRECATION: false
windows:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 18
Expand All @@ -40,7 +54,7 @@
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: 18
Expand Down
4 changes: 3 additions & 1 deletion .kokoro/samples-test.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.