Skip to content

Conversation

@ReubenFrankel
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Partially addresses #857 🦕

@ReubenFrankel ReubenFrankel requested review from a team as code owners October 31, 2025 04:43
@google-cla
Copy link

google-cla bot commented Oct 31, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 31, 2025
@ReubenFrankel ReubenFrankel changed the title Fix/version check error log fix: Log version check errors Oct 31, 2025
@chalmerlowe
Copy link
Contributor

@ReubenFrankel Thanks for this PR. I would like to see the logger type and message modified a bit. Please accept the suggestion and I will approve.

If you have a strong objection to the suggestion, I am happy to hear your reasoning.

@ReubenFrankel
Copy link
Contributor Author

If you have a strong objection to the suggestion, I am happy to hear your reasoning.

No objections, I kept the message the same only because that was what was there before and the intention of the PR was to move from print to logging.

chalmerlowe
chalmerlowe previously approved these changes Nov 4, 2025
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ReubenFrankel
Copy link
Contributor Author

If the fix for underlying cause is simple (i.e. adjusting the version check), I'm happy to expand this PR to cover that also.

@ReubenFrankel ReubenFrankel force-pushed the fix/version-check-error-log branch from 923af21 to 1314e81 Compare November 4, 2025 12:10
@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2025
@Linchin Linchin self-requested a review November 4, 2025 19:26
@chalmerlowe chalmerlowe merged commit 6493118 into googleapis:main Nov 4, 2025
45 of 46 checks passed
@chalmerlowe
Copy link
Contributor

Thank you @ReubenFrankel!

@ReubenFrankel ReubenFrankel deleted the fix/version-check-error-log branch November 4, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants