Refactor select to not create objects #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of a SelectCase object was making specifying select harder because it requires managing heap state.
The new implementation takes the channel reference, direction (SelectSend/SelectRecv), and value directly as parameters to the select functions. This eliminates the need to construct and manage intermediate case objects on the heap. The downside is that there are parameters and return values that aren't used depending on whether it it a send or receive.
Key changes:
Select1/2/3
functions that took ablocking
bool parameter into separateNonBlockingSelect1/2/3
andBlockingSelect1/2/3
functions for clarity(selected/caseIndex, received_value1, received_value2, ..., ok)
=> No permutation generation or duplicate-checking logic needed
Perennial regoose PR: mit-pdos/perennial#393