-
Notifications
You must be signed in to change notification settings - Fork 45
sysBtn and flexible config mobileKeyboard #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hwcctn
wants to merge
6
commits into
goplus:trailhead_sharing
Choose a base branch
from
hwcctn:trailhead_sharing_goplus_dev
base: trailhead_sharing
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−73
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8dcf275
sysBtn and flexible config mobileKeyboard
hwcctn 603c43c
fix: Fields and index.md problem
hwcctn 8520182
fix: index
hwcctn 0bf6d9a
fix:annotation and sysBtn effectuation
hwcctn cb39e39
delete:config Btn size
hwcctn db6fa31
update MobileKeyboardZoneToKeyMapping to MobileKeyboardBtns
hwcctn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,29 +4,15 @@ import type { | |
| } from "../../../spx-gui/src/apis/common/index.ts"; | ||
| import { type ProjectRelease } from "../../../spx-gui/src/apis/project-release.ts"; | ||
|
|
||
| /** | ||
| * Valid mobile keyboard zones | ||
| */ | ||
| export const MOBILE_KEYBOARD_ZONES = [ | ||
| "lt", | ||
| "rt", | ||
| "lbUp", | ||
| "lbLeft", | ||
| "lbRight", | ||
| "lbDown", | ||
| "rbA", | ||
| "rbB", | ||
| "rbX", | ||
| "rbY", | ||
| ] as const; | ||
|
|
||
| export type MobileKeyboardZone = (typeof MOBILE_KEYBOARD_ZONES)[number]; | ||
| /** | ||
| * Zone to key mapping for mobile keyboard | ||
| */ | ||
| export type MobileKeyboardZoneToKeyMapping = { | ||
| [zone in MobileKeyboardZone]: string | null; | ||
| export type KeyBtn = { | ||
| /** The text displayed on the key. */ | ||
| label: string; | ||
| /** The horizontal coordinate of the left top corner of the key (pixels). */ | ||
| posX: number; | ||
| /** The vertical coordinate of the left top corner of the key (pixels). */ | ||
| posY: number; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 还缺了说明“这个 btn 绑定的是哪个 key”的字段? |
||
| }; | ||
| export type MobileKeyboardBtns = KeyBtn[]; | ||
| /** | ||
| * Mobile keyboard type | ||
| * - NoKeyboard: No keyboard | ||
|
|
@@ -77,7 +63,7 @@ export type ProjectData = { | |
| /** Mobile keyboard type */ | ||
| mobileKeyboardType: MobileKeyboardType; | ||
| /** Zone to key mapping for mobile keyboard */ | ||
| mobileKeyboardZoneToKey?: MobileKeyboardZoneToKeyMapping; | ||
| mobileKeyboardBtns?: MobileKeyboardBtns; | ||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -95,7 +81,7 @@ export type AddProjectParams = { | |
| /** Mobile keyboard type */ | ||
| mobileKeyboardType: MobileKeyboardType; | ||
| /** Zone to key mapping for mobile keyboard */ | ||
| mobileKeyboardZoneToKey?: MobileKeyboardZoneToKeyMapping; | ||
| mobileKeyboardBtns?: MobileKeyboardBtns; | ||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -111,7 +97,7 @@ export type AddProjectByRemixParams = { | |
| /** Mobile keyboard type */ | ||
| mobileKeyboardType: MobileKeyboardType; | ||
| /** Zone to key mapping for mobile keyboard */ | ||
| mobileKeyboardZoneToKey?: MobileKeyboardZoneToKeyMapping; | ||
| mobileKeyboardBtns?: MobileKeyboardBtns; | ||
| }; | ||
|
|
||
| /** | ||
|
|
@@ -131,7 +117,7 @@ export type UpdateProjectParams = { | |
| /** Mobile keyboard type */ | ||
| mobileKeyboardType?: MobileKeyboardType; | ||
| /** Zone to key mapping for mobile keyboard */ | ||
| mobileKeyboardZoneToKey?: MobileKeyboardZoneToKeyMapping; | ||
| mobileKeyboardBtns?: MobileKeyboardBtns; | ||
| }; | ||
|
|
||
| /** | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另外还有 #2133 (comment) 这个问题需要考虑下