Skip to content

fix(auth): prevent race condition on user creation with DB-level uniqueness #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(auth): prevent race condition on user creation with DB-level uniqueness #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 34 additions & 52 deletions src/app/routes/auth/auth.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,35 +6,6 @@ import { RegisteredUser } from './registered-user.model';
import generateToken from './token.utils';
import { User } from './user.model';

const checkUserUniqueness = async (email: string, username: string) => {
const existingUserByEmail = await prisma.user.findUnique({
where: {
email,
},
select: {
id: true,
},
});

const existingUserByUsername = await prisma.user.findUnique({
where: {
username,
},
select: {
id: true,
},
});

if (existingUserByEmail || existingUserByUsername) {
throw new HttpException(422, {
errors: {
...(existingUserByEmail ? { email: ['has already been taken'] } : {}),
...(existingUserByUsername ? { username: ['has already been taken'] } : {}),
},
});
}
};

export const createUser = async (input: RegisterInput): Promise<RegisteredUser> => {
const email = input.email?.trim();
const username = input.username?.trim();
Expand All @@ -53,32 +24,43 @@ export const createUser = async (input: RegisterInput): Promise<RegisteredUser>
throw new HttpException(422, { errors: { password: ["can't be blank"] } });
}

await checkUserUniqueness(email, username);
try {
const hashedPassword = await bcrypt.hash(password, 10);

const user = await prisma.user.create({
data: {
username,
email,
password: hashedPassword,
...(image ? { image } : {}),
...(bio ? { bio } : {}),
...(demo ? { demo } : {}),
},
select: {
id: true,
email: true,
username: true,
bio: true,
image: true,
},
});

const hashedPassword = await bcrypt.hash(password, 10);
return {
...user,
token: generateToken(user.id),
};
} catch (err: any) {
if (err.code === "P2002" && Array.isArray(err.meta?.target)) {
const errors: Record<string, string[]> = {};

const user = await prisma.user.create({
data: {
username,
email,
password: hashedPassword,
...(image ? { image } : {}),
...(bio ? { bio } : {}),
...(demo ? { demo } : {}),
},
select: {
id: true,
email: true,
username: true,
bio: true,
image: true,
},
});
for (const field of err.meta.target as string[]) {
errors[field] = ["has already been taken"];
}

return {
...user,
token: generateToken(user.id),
};
throw new HttpException(422, { errors });
}
throw err;
}
};

export const login = async (userPayload: any) => {
Expand Down