feat: add support for custom policy steps #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjali9791
force-pushed
the
feat/dynamic_policy_steps
branch
7 times, most recently
from
fb340a0 to
f6fb1b9
Compare
anjali9791
changed the title
anjali9791
force-pushed
the
feat/dynamic_policy_steps
branch
3 times, most recently
from
2313f22 to
b0af645
Compare
rahmatrhd
reviewed
Sep 23, 2025
| return fmt.Errorf("getting custom steps : %w", err) | ||
| } | ||
| if steps != nil { | ||
| policy.Steps = append(policy.Steps, steps...) |
There was a problem hiding this comment.
Suggested change
| policy.Steps = append(policy.Steps, steps...) | |
| policy.Steps = steps |
we don't want to combine it with the normal steps I believe?
There was a problem hiding this comment.
We want to add it to the normal steps.
| } | ||
| } | ||
|
|
||
| if p.HasCustomSteps() { |
There was a problem hiding this comment.
let's validate that only either one steps or custom_steps is allowed?
There was a problem hiding this comment.
@rahmatrhd : I did not get this part. Can you elaborate
There was a problem hiding this comment.
both configs can't exist at the same time in one policy
There was a problem hiding this comment.
Both configs can exist. Example in case of package: policy config will have package's admin approval and custom steps will add approvers from the resources which are part of the package.
anjali9791
force-pushed
the
feat/dynamic_policy_steps
branch
8 times, most recently
from
89759a5 to
b3cac85
Compare
rahmatrhd
changed the title
rahmatrhd
reviewed
Sep 29, 2025
anjali9791
force-pushed
the
feat/dynamic_policy_steps
branch
from
03e84c9 to
3af3011
Compare
anjali9791
force-pushed
the
feat/dynamic_policy_steps
branch
from
425fa2d to
b9d1e07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proton PR: goto/proton#166