Add Web UI to Spring Shell demo #366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Wasm code runs in a Web Worker, which is fed commands as the user types them in.
oracle-contributor-agreement
bot
added
the
OCA Verified
fniephaus
requested changes
Oct 27, 2025
| @@ -0,0 +1,74 @@ | |||
| import { AnsiUp } from "./ansi_up.js"; | |||
| </executions> | ||
| <configuration> | ||
| <imageName>../web/wasm-spring-shell</imageName> | ||
| <buildArgs> |
Member
There was a problem hiding this comment.
I think with something like this, you can append -H:-AutoRunVM to the default list, and not repeat and override it:
Suggested change
| <buildArgs> | |
| <buildArgs combine.children="append"> |
| @@ -0,0 +1,10 @@ | |||
| globalThis.sharedBuffer = new SharedArrayBuffer(65536); | |||
| @@ -0,0 +1,46 @@ | |||
| package com.example.wasm_spring_shell.web; | |||
| @@ -0,0 +1,72 @@ | |||
| package com.example.wasm_spring_shell.web; | |||
Member
There was a problem hiding this comment.
Add copyright header, here and in all other .java files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wasm code runs in a Web Worker, which is fed commands as the user types them in.