Skip to content

Commit 8de6d1c

Browse files
authored
Merge pull request #122 from gradle/no/bump-latest
Support latest 4.2.0-alpha11 and 4.1.0-rc3
2 parents e5a9883 + 5655134 commit 8de6d1c

File tree

3 files changed

+17
-5
lines changed

3 files changed

+17
-5
lines changed

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ version = ["git", "describe", "--match", "[0-9]*", "--dirty"].execute().text.tri
1212

1313
// Maps supported Android plugin versions to the versions of Gradle that support it
1414
def supportedVersions = [
15-
"4.2.0-alpha10": ["6.6.1"],
16-
"4.1.0-rc02": ["6.5.1"],
15+
"4.2.0-alpha12": ["6.6.1"],
16+
"4.1.0-rc03": ["6.5.1"],
1717
"4.0.1": ["6.1.1", "6.3", "6.4.1"],
1818
"3.6.4": ["5.6.4", "6.3", "6.4.1"],
1919
"3.5.4": ["5.4.1", "5.6.4", "6.3", "6.4.1"]

src/test/groovy/org/gradle/android/CrossVersionOutcomeAndRelocationTest.groovy

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ class CrossVersionOutcomeAndRelocationTest extends AbstractTest {
141141
def isAndroid40x = androidVersion >= android("4.0.0") && androidVersion < android("4.1.0-alpha01")
142142
def isAndroid40xTo41x = androidVersion >= android("4.0.0") && androidVersion <= android("4.2.0-alpha01")
143143
def isAndroid41xOrHigher = androidVersion >= android("4.1.0-alpha01")
144+
def isandroid41x = androidVersion >= android("4.1.0-alpha01") && androidVersion < android("4.2.0-alpha01")
144145
def isAndroid42xOrHigher = androidVersion >= android("4.2.0-alpha01")
145146
def builder = new ExpectedOutcomeBuilder()
146147

@@ -196,6 +197,10 @@ class CrossVersionOutcomeAndRelocationTest extends AbstractTest {
196197
android41xOrHigherExpectations(builder)
197198
}
198199

200+
if (isandroid41x) {
201+
android41xOnlyExpectations(builder)
202+
}
203+
199204
if (isAndroid42xOrHigher) {
200205
android42xOrHigherExpectations(builder)
201206
}
@@ -470,13 +475,16 @@ class CrossVersionOutcomeAndRelocationTest extends AbstractTest {
470475
builder.expect(':app:compressDebugAssets', FROM_CACHE)
471476
builder.expect(':app:compressReleaseAssets', FROM_CACHE)
472477
builder.expect(':app:mergeDebugNativeDebugMetadata', NO_SOURCE)
473-
builder.expect(':app:mergeReleaseNativeDebugMetadata', NO_SOURCE)
474478
builder.expect(':app:checkDebugAarMetadata', FROM_CACHE)
475479
builder.expect(':app:checkReleaseAarMetadata', FROM_CACHE)
476480
builder.expect(':library:writeDebugAarMetadata', FROM_CACHE)
477481
builder.expect(':library:writeReleaseAarMetadata', FROM_CACHE)
478482
}
479483

484+
static void android41xOnlyExpectations(ExpectedOutcomeBuilder builder) {
485+
builder.expect(':app:mergeReleaseNativeDebugMetadata', NO_SOURCE)
486+
}
487+
480488
static void android40xOnlyExpectations(ExpectedOutcomeBuilder builder) {
481489
builder.expect(':app:dataBindingExportBuildInfoDebug', FROM_CACHE)
482490
builder.expect(':app:dataBindingExportBuildInfoRelease', FROM_CACHE)
@@ -491,6 +499,10 @@ class CrossVersionOutcomeAndRelocationTest extends AbstractTest {
491499
builder.expect(':library:bundleLibRuntimeToDirDebug', FROM_CACHE)
492500
builder.expect(':library:bundleLibRuntimeToDirRelease', FROM_CACHE)
493501
builder.expect(':app:optimizeReleaseResources', FROM_CACHE)
502+
builder.expect(':app:mergeReleaseNativeDebugMetadata', FROM_CACHE)
503+
builder.expect(':app:writeDebugAppMetadata', FROM_CACHE)
504+
builder.expect(':app:extractReleaseNativeSymbolTables', FROM_CACHE)
505+
builder.expect(':app:writeReleaseAppMetadata', FROM_CACHE)
494506
// New non-cacheable tasks in 4.2.0-alpha10:
495507
builder.expect(':app:writeReleaseApplicationId', SUCCESS)
496508
builder.expect(':app:analyticsRecordingRelease', SUCCESS)

src/test/groovy/org/gradle/android/WorkaroundTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ class WorkaroundTest extends Specification {
1212
workarounds.collect { it.class.simpleName.replaceAll(/Workaround/, "") }.sort() == expectedWorkarounds.sort()
1313
where:
1414
androidVersion | expectedWorkarounds
15-
"4.2.0-alpha10" | ['RoomSchemaLocation', 'CompileLibraryResources_4_2', 'MergeResources', 'DexFileDependencies']
16-
"4.1.0-rc02" | ['RoomSchemaLocation', 'CompileLibraryResources_4_0', 'MergeResources', 'DexFileDependencies']
15+
"4.2.0-alpha12" | ['RoomSchemaLocation', 'CompileLibraryResources_4_2', 'MergeResources', 'DexFileDependencies']
16+
"4.1.0-rc03" | ['RoomSchemaLocation', 'CompileLibraryResources_4_0', 'MergeResources', 'DexFileDependencies']
1717
"4.0.1" | ['MergeJavaResources', 'MergeNativeLibs', 'RoomSchemaLocation', 'CompileLibraryResources_4_0', 'MergeResources', 'DexFileDependencies']
1818
"3.6.4" | ['MergeJavaResources', 'MergeNativeLibs', 'RoomSchemaLocation', 'DexFileDependencies']
1919
"3.5.4" | ['MergeJavaResources', 'RoomSchemaLocation', 'DexFileDependencies']

0 commit comments

Comments
 (0)