Add handling for new grafana assume role keys #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
idastambuk and
njvrzm
and removed request for
a team
njvrzm
requested changes
Oct 3, 2025
| } | ||
|
|
||
| creds := client.NewStaticCredentialsProvider(string(accessKey), string(secretKey), "") | ||
| _, err := creds.Retrieve(ctx) |
There was a problem hiding this comment.
Unfortunately this doesn't actually validate the credentials - you don't get an error regardless of what strings you pass in. We could validate them here by using GetCallerIdentity or the like, but that takes a nontrivial amount of time so we probably don't want to do it every time.
One approach would be to set a global to aws-temp-credentials-1 and use that when choosing keys, then in WithAssumeRole if we get an error indicating the credentials are invalid (have to check what that looks like) we switch the global to aws-temp-credentials-2 and retry (once).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new keys are located at a new folder and there may be multiple of them, so updating the logic for that.