Fix interval check for 2y case in gtime.go #1422
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 3628800000 ms is equal to 42 days any range longer than that falls to the default case which is 1 year. I updated the condition to 63072000000 ms which is 2 years.
mertyldrm
requested review from
aangelisc,
adamyeats,
alyssajoyner,
bossinc and
zoesyc
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
|
|
grafana-plugins-platform-bot
bot
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
itsmylife
requested changes
Oct 24, 2025
github-project-automation
bot
moved this from 🔬 In review
to 🧑💻 In development
in Plugins Platform / Grafana Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Round IntervalFunction under gtime.go file had a faulty condition for 2 years range, since the condition was set to 42 days in ms, every interval longer than 42 days was set to 1 years of interval.
Which issue(s) this PR fixes: This PR fixes the case for 2 years by fixing the condition to 2 years in ms
Fixes
I updated the condition to 63072000000 ms which is 2 years.
Special notes for your reviewer: