-
Notifications
You must be signed in to change notification settings - Fork 16
Add data sources writing guidelines #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Readability report
View metric targets
|
This comment has been minimized.
This comment has been minimized.
|
💻 Deploy preview available: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! This is great guidance for data source documentation.
I still think this document makes more sense in the Writers' Toolkit IA under Structure since it primarily discusses structuring data source documentation.
@chri2547 wdyt?
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jack Baldry <[email protected]>
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jack Baldry <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
@jdbaldry , @lwandz13 - yes, this kind of content belongs in the Structure area, and it should include screenshots that show the parts of the docs. Because data source docs have multiple documents, I would nest them under a parent, like: Structure In addition, each of the doc types listed above should have a corresponding template. |
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
|
|
||
|
|
||
| Enterprise plugins reside in the [`grafana/plugins-private`](https://github.com/grafana/plugins-private) repository, which is a private repository. | ||
| Other plugins have their own separate repos, and you need to clone each repo to work on data source documentation updates. |
Check warning
Code scanning / Vale
Use 'repositories' instead of 'repos'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: repositories. Warning documentation
|
|
||
|
|
||
| Enterprise plugins reside in the [`grafana/plugins-private`](https://github.com/grafana/plugins-private) repository, which is a private repository. | ||
| Other plugins have their own separate repos, and you need to clone each repo to work on data source documentation updates. |
Check warning
Code scanning / Vale
Use 'repository' instead of 'repo'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: repository. Warning documentation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
|
||
| ## "Get the most out of the data source | ||
|
|
||
| Once you have connected the <INSERT NAME> data source, you can: |
Check warning
Code scanning / Vale
Use 'After' instead of 'Once'.. For more information, refer to https://grafana.com/docs/writers-toolkit/write/style-guide/word-list/. To fix this, Replace the matched content with one of the following: After. Warning documentation
This comment has been minimized.
This comment has been minimized.
|
@chri2547 @jdbaldry Hear me out on this: I think this doc belongs under Contribute, since it provides guidance for both internal and external developers on how to create and update data source documentation. Placing it there also helps ensure that information about contributing to non–Grafana managed data sources is easy to find and consistent with the rest of our docs. Thoughts? If you still feel very strongly that I move this, I will. |
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
Co-authored-by: Jack Baldry <[email protected]>
I think that applies to all of Writers' Toolkit documentation though, right?
I'm no expert on IA, I'm not sure if it's easier to find in Contribute or Structure. I guess if I were a data source dev, I wouldn't know to click on either to find documentation for how to write my data source documentation |
Adding the data sources writing guideline to Writers' Toolkit. Please ensure that:
Users outside Grafana will see this, so ensure that no proprietary information is included.