Skip to content

Change selection of top image #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Change selection of top image #122

wants to merge 5 commits into from

Conversation

mwjackson
Copy link

A few tweaks in this PR:

  • leave local image comparison as a last resort, as its the most costly
  • added timeout to image fetching as some bad behaved (or nginx 444 status) cause goose to hang
  • look for twitter card image as potential image source

mwjackson added 5 commits July 18, 2014 16:22
@mwjackson
try to find images using least costly methods
ea0583c 
save full image retrieval until last and make configurable (instead of all images on/off)
use curated tags (opengraph, twitter card) where possible
@mwjackson
ignore .env
3fd0581
@mwjackson
added socket timeout to image retrieval
2ac8236 
handles 444 back from nginx a little better
@mwjackson
made timeout 15 seconds
ad5d087
@mwjackson
only check image dimensions if image fetching enabled
d18ed20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mwjackson