feat: support batch queries #550
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
reviewed
Oct 13, 2025
| client: &reqwest::blocking::Client, | ||
| url: U, | ||
| variables: Vec<Q::Variables>, | ||
| ) -> Result<crate::Response<Q::ResponseData>, reqwest::Error> { |
There was a problem hiding this comment.
Shouldn't this be Result<Vec<crate::Response<...>>, _>?
There was a problem hiding this comment.
it will be serde_json::Array
There was a problem hiding this comment.
I think the shape of the ResponseData is from generated code, not a serde_json::Value, so I don't think serde_json::Array would appear anywhere, right?
There was a problem hiding this comment.
Also, this approach only works if it's a batch of the same query — in GraphQL, the queries can be different. It would not be straightforward to statically type, though.
|
@tomhoule could you please launch the tests again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for executing multiple GraphQL operations in a single HTTP request (batch query).
This enables sending an array of query objects with their respective variables, improving performance for use cases that require multiple small requests.
Includes:
Support for serializing and sending batched query payloads.
Adjusted request builder to handle both single and batch query modes.
Unit tests covering multi-query payload serialization and response handling.