-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add nullMode for area, bar-x, bar-y, heatmap, line, pie, scatter, waterfall charts #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview is ready. |
|
Visual Tests Report is ready. |
|
@arteria32 Hey! First of all - thank you for contribution! We have discussed your PR with @kuzmadom and wanna ask you to make some corrections:
type SomeSeries = {
// ...
**
* @property nullMode - How to handle null/undefined values
* - 'skip': omit the data point (creates gap in line, no bar shown)
* - 'zero': treat as zero value
* - 'connect': connect points across null (line/area only)
*/
nullMode: 'skip' | 'zero' | 'connect'
// ...
};
|
… multiple story files
done
I have simplified all the stories for the null mode demo.
I have forbidden null values for datetime axes in the validation function. I believe that zero replacement or skipping mode is not suitable for this type.
Done
|
No description provided.