Skip to content

fix: clean up resize observer #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: clean up resize observer #461

wants to merge 2 commits into from

Conversation

DarkGenius
Copy link
Collaborator

@DarkGenius DarkGenius commented Aug 24, 2025 •
edited
Loading

Summary

  • ensure ResizeObserver is disconnected and debounced callback cancelled in useOverflowingHorizontalListItems

Testing

  • npm test
  • npm run lint:js

https://chatgpt.com/s/cd_68ab477293d081918541317bf42bb49b

Summary by CodeRabbit

  • New Features
    • No user-facing features added.
  • Bug Fixes
    • Prevented rare initialization errors when the footer menu isn’t present.
    • Ensured width updates only occur when the element exists, avoiding null access.
  • Refactor
    • Improved cleanup of observers and debounced handlers to reduce potential leaks and stabilize behavior.
  • Tests
    • No changes.
  • Documentation
    • No changes.

@DarkGenius DarkGenius added the codex Contains code generated by ChatGPT Codex label Aug 24, 2025
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Playwright Test Component is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunory Lunory Awaiting requested review from Lunory Lunory is a code owner

@kendoow kendoow Awaiting requested review from kendoow kendoow is a code owner

@BlackPoretsky BlackPoretsky Awaiting requested review from BlackPoretsky BlackPoretsky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
codex Contains code generated by ChatGPT Codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarkGenius @gravity-ui-bot