Skip to content

fix: copyClipboard #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: copyClipboard #2432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/CopyToClipboard/copyText.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export function copyText(text: string) {
if (typeof navigator !== 'undefined' && navigator.clipboard?.writeText) {
try {
return navigator.clipboard.writeText(text);
navigator.clipboard.writeText(text);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How this solves the problem?

Copy link
Contributor

@amje amje Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writeText returns a Promise, so if it fails normally (security issue) we'll never get into the catch block and run fallback

Copy link
Contributor

@amje amje Sep 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should we async/await function to work correctly indeed

} catch (error) {
return typeof document === 'undefined' ? Promise.reject(error) : copyTextFallback(text);
}
Expand Down