feat: add insert functionality to BaseVectorStorageDriver #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wassim-Hamra
force-pushed
the
feature/add-inserts-BaseVectorStorageDriver
branch
from
b493a38 to
b3ae05a
Compare
…eVectorStorageDriver
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added two methods to BaseVectorStoreDriver: insert (single-item regular insert) and insert_collection (batch insert). They mirror upsert/upsert_collection but generate a random uuid4 when no vector_id is provided so repeated inserts create new entries instead of deduplicating.
Issue ticket number and link
ticket num: 50