update pyodide from 0.23.4 to 0.28.1 #1754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some significant performance improvements in 0.24: https://blog.pyodide.org/posts/0.24-release/ They aren't particularly helpful for pyodide-in-node, but could be helpful for grist-static. Another development is support for snapshotting which could be a huge help, however this isn't mature enough yet to use.
fflorent
reviewed
Aug 13, 2025
| @@ -0,0 +1,33 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| # Usage: ./clean_if_new_version.sh N | |||
There was a problem hiding this comment.
Hmm, part of me wonders what happens when this script is not called using ./ but from another destination (like the root of the grist-core project).
But maybe it is rather expected that these scripts are called using Make, so not very relevant.
| source env.sh | ||
| cd _build/pyodide | ||
| git checkout 0.23.4 || (git fetch && git checkout 0.23.4) | ||
| git checkout $PYODIDE_VERSION || (git fetch && git checkout $PYODIDE_VERSION) |
There was a problem hiding this comment.
Above the script starts with set -e.
What do you think of adding the -u option? I think it can be especially useful when you are using variables:
-u Treat unset variables as an error when substituting.
(usually I work with set -eEuo pipefail which covers many cases of error)
| cd _build/worker | ||
| yarn init --yes | ||
| yarn add pyodide@0.23.4 | ||
| yarn add pyodide@$PYODIDE_VERSION |
There was a problem hiding this comment.
Idem, maybe use set -eu above to be sure this variable is set.
| "friendly_traceback-0.7.48-cp313-none-any.whl", | ||
| "iso8601-0.1.12-cp313-none-any.whl", | ||
| "lazy_object_proxy-1.6.0-cp313-cp313-pyodide_2025_0_wasm32.whl", | ||
| "openpyxl-3.0.10-cp313-none-any.whl", |
There was a problem hiding this comment.
Are these changes related to the python version? (3.11 -> 3.13)
fflorent
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some significant performance improvements in 0.24:
https://blog.pyodide.org/posts/0.24-release/
They aren't particularly helpful for pyodide-in-node, but could be helpful for grist-static. Another development is support for snapshotting which could be a huge help, however this isn't mature enough yet to use.