-
-
Notifications
You must be signed in to change notification settings - Fork 489
Updating webpack-cli and webpack-dev-server. Adding projects test to CI #1814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5b6ab2e to
2b1e26b
Compare
|
@berhalak what do you think about the test failure? |
|
@berhalak I think I can replicate the failure locally with something like: I think removing |
4daeefe to
b1f178f
Compare
Thanks for finding this out @paulfitz! I'm still not happy that this doesn't work for projects (while it does work for nbrowser tests), but couldn't find the reason, and I think this is good as it is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jumping in while Paul is out. This looks good, and thank you for fixing all those tests! I have a couple minor comments, non-blocking.
|
|
||
| describe('UserManager', () => { | ||
| setupTestSuite(); | ||
| gu.bigScreen(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? (I always have to adjust when I run such tests locally because bigScreen is bigger than my physical screen)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. It will fail with the full browser without it. But the size of the window can be adjusted globally (Cyprian already raised that issue before), I will propose a change as a DIFF as more test will be affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have gu.bigScreen('medium'), and to me that would be a more convenient default. Totally fine to leave as is in this PR.
test/nbrowser/gristUtils.ts
Outdated
| * Waits until all text in the given input element is selected and the element has focus. | ||
| * @param inputSelector Selector for the input element to check selection on. | ||
| */ | ||
| export async function waitForSelection(inputSelector: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be better to keep in "ColorSelect", since it's rather specific to the needs of that test? If you'd rather expose it here for other purposes, then I think it needs a clearer name, since "selection" is used for several different things in our tests (like cell ranges, or selected menu items). Maybe "waitForInputFullSelection"? It could also accept a WebElement, for better generality (you can pass one to executeScript, e.g. as for scrollIntoView)
Context
projectstests are now added to CIRelated issues
#1811
Has this been tested?
Existing test should pass.