Show a "record is unavailable" message when a user opens a record card blocked by ACLs #1896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Spoffy
force-pushed
the
spoffy/fix-record-card-when-hidden-by-acl-null-rowindex
branch
from
0fd1d8e to
6527461
Compare
|
This will be really helpful. Thank you! |
berhalak
reviewed
Oct 30, 2025
| const cursor = await section.findWait('.selected_cursor', 1000); | ||
| let cursor: WebElement; | ||
| try { | ||
| cursor = await section.findWait('.selected_cursor', 1000); |
There was a problem hiding this comment.
Can you add a comment here, what was wrong, and why there might not be cursor in a section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When a record card is opened for a row that is unavailable (blocked by access control), currently it shows a "random" record.
This occurs because Cursor refuses to be set to non-existent row ids, and instead maintains the current rowIndex. This is usually the last one viewed, or rowIndex 0.
Proposed solution
This solution is option 2 of 2.
CursorsupportsrowIndexbeing set to null currently, but this generally doesn't occur due toCursorclamping the row indexes.This uses the Cursor's null rowIndex as an 'Invalid record selected' state, and updates the record view to show a message when the rowIndex is null.
Related issues
#1895 - Option 1 - Show a notification and a blank card
Has this been tested?
Screenshots / Screencasts