Skip to content

Conversation

spencerrlongg
Copy link
Collaborator

@spencerrlongg spencerrlongg commented Apr 23, 2025

This adds a condition and redirect for when you've selected to print labels with the Location as the target, and one or any of the assets don't have a location. (I'm all for making that error clearer, that was the first thing I came up with and now I can't think of a better way to say it)

fixes #SC-28974

@spencerrlongg spencerrlongg requested a review from snipe as a code owner April 23, 2025 17:40
@snipe
Copy link
Member

snipe commented Jun 2, 2025

Would we want to do a full redirect, or just leave those labels out of the label sheet?

@spencerrlongg
Copy link
Collaborator Author

There was a problem with that... I can't remember exactly what the problem was though since it's been a while. I can look at it tomorrow.

@spencerrlongg
Copy link
Collaborator Author

Oh, I misread your comment. I think I'd rather a redirect, I'm not necessarily going to count how many labels are shown when I go to print, and I think it'd be confusing if it printed everything except for one that didn't happen to have a location and I didn't realize that.

@snipe
Copy link
Member

snipe commented Jun 2, 2025

I think the more expected response would be to skip the ones that don't have a location. It would be pretty frustrating to select 200 assets, print their labels, and then keep getting redirected without knowing which one was causing it to fail.

@spencerrlongg
Copy link
Collaborator Author

But then you wouldn't necessarily know that any have been skipped, which would also be frustrating. I don't know, I'll play around with some other kind of messaging maybe on the pdf itself? Or maybe a better error message that lists the tags that don't have locations?

@snipe
Copy link
Member

snipe commented Sep 8, 2025

If we put that messaging on the PDF, I think we'd want it in some sort of unprintable div, otherwise it would throw off the layout. If we were to signal that in the label PDF itself, we'd be making people waste labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants