Fixed: disabled Category EULA box when no Default EULA created #16913
Conversation
There was a problem hiding this comment.
Hm...this isn't exactly working right. It doesn't handle the case where a category is set to use the default eula but the default eula is not set.
For example, without a global EULA set while editing this category:
The "Use default eula" is correctly not checked but once I remove the category eula it becomes checked/disabled.
Also the notice continues to say " An email will be sent to the user because the global EULA is being used."
| type="checkbox" | ||
| name="use_default_eula" | ||
| value="0" | ||
| wire:model.live="shouldUncheckDefaultEulaBox" |
There was a problem hiding this comment.
wire:model should be used for properties and not event listeners/handlers.
I think ensuring $useDefaultEula is accurate is the correct fix?
Maybe we can make sure we're in a valid state from the start from within the mount method?
There was a problem hiding this comment.
I see this. For some reason i probably didn't do that combo of actions, cause I don't remember that happening.
Additionally, the checkmark for "use default EULA" persists on the category index page, even when no default EULA is made. so that is another spot we'd have to fix as well.
There was a problem hiding this comment.
or do we want to leave it there, but make sure the checkbox is always uncheckable if its checked, but then we don't allow it to be rechecked?
There was a problem hiding this comment.
so, yea, that checkmark WILL change upon another save of the edit page. so its not a huge issue, but could be confusing.
if there is no default eula set, then useDefaultEula should always be false. At no point it should ever turn true, I don't think it ever does.
So, it might just be a mess with reading the correct true/false and then presenting it on the page.
|
This has been open for a while - can we make sure we get this handled this week please? |
fixes: SC-29119
EULA on the Category settings page for each category was disabled while there was no default EULA made, even when there was a EULA specifically set on the Category itself.
This makes it so that EULA is always editable, and if there is no Default EULA, then it will uncheck and grey out the "use Default EULA" option