fix(#794): Wrapping codes.OK should not cause panic #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An panic was raised in
wrappedErrField.Error()
whenPingError
was used without specifying theErrorCodeReturned
.See #794 for a description of the original issue, with context.
It turns out it is possible to build a
wrappedErrFields
which has awrappedErr == nil
.Changes
Added some safety nets in the calls accessing the
err.wrappedErr
field.Verification
Added a unit test that covers the "usual" scenario (when the
ErrorCodeReturned
was properly set) and the edge-case scenario (when noErrorCodeReturned
was set).