Fixed an issue with ambiguous Unsubscribe and introduced Consume #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssage-less variant. Also added a Consume flag to the base message interface that allows the first subscriber to completely consume the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After my previous pull request introduced an Unsubscribe that was message-less it breaks the reflection that looks for the Unsubscribe method, there's multiple now so it gets confused.
To that end I've fixed up the reflection so it finds the correct one.
I also had the need to only process the message once by one subscriber where there could be multiple subscribers listening for the message. To resolve this I introduced a Consume flag into ITinyMessage and also fixed up some of the base/abstract classes that depend on it.
I'm not too sure on changing ITinyMessage directly, it could break anything that inherits from it. Generally I've always based my messages on TinyMessageBase but open to solutions around this, not sure, another interface to look for?