This repository was archived by the owner on Dec 28, 2017. It is now read-only.
Configuring Calling Format for S3 URLs #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging alleged connection issues with a secure site that uses S3 storage has revealed that in some instances, the default
SubdomainCallingFormatused byboto.s3.connection.S3Connectionfor S3 bucket URLs can trip SSL certificate authentication in browsers, since wildcarded subdomains are being deprecated (http://tools.ietf.org/html/rfc6125#section-7.2). In some cases over HTTPS, this could trigger a browser warning, and Internet Explorer 10 on Windows 8 can even hide the issue behind an opaque "Connection Error."For this reason, I believe the default (indeed, for
botoas well) should beboto.s3.connection.OrdinaryCallingFormat. I have therefore taken an opinionated approach here of usingOrdinaryCallingFormatby default when callingS3Connectionand allowing the user to configure the calling format otherwise using setting import string insettings.URL_CALLING_FORMAT. For more details, please review the documentation update and the addition toS3BotoStorage.__init__().