-
Notifications
You must be signed in to change notification settings - Fork 11
speculative decoding support #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
natehofmann
wants to merge
65
commits into
guidance-ai:main
Choose a base branch
from
natehofmann:nathof/spec-decode-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
speculative decoding support #25
natehofmann
wants to merge
65
commits into
guidance-ai:main
from
natehofmann:nathof/spec-decode-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into nathof/spec-decode-support
…mann/llgtrt into nathof/spec-decode-support
Member
|
I think the spec-decoding logic should sit in
When a request from user is added (assume n_draft_tokens=5)
This way you don't have to mess with completions.rs much. |
…lgtrt into nathof/spec-decode-support
…ofmann/llgtrt into nathof/spec-decode-support
265cdd4 to
4dc658a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build off of liangjason87:liangjason/spec_decoding, but with rough Rust layer. haven't tried yet, things still all over the place. keeping to simple, non-stream, non-lora case