Skip to content

Conversation

aloysboscariol
Copy link
Contributor

@aloysboscariol aloysboscariol commented Aug 25, 2025

Your checklist for this pull request

Author name

Author:
Aloys

About your game

What is your game about?
Killing the aliens before they invade the earth

How do you play your game?

  • Use "A" and "D" to move your ship left and right
  • Use "W" to shoot bullets
  • Destroy the aliens before they reach the bottom
  • The game ends if an alien touches your row

Menu Instructions:

  • Use "W" and "S" to navigate
  • Use "J" to select / confirm
  • Press "K" to go back to the main menu

Code

Check off the items that are true.

  • The game was made using the Sprig editor.
  • The game is placed in the in the /games directory.
  • The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
  • The game runs without errors.
  • The name of the file/game contains only alphanumeric characters, -s, or _s.
  • The game name is not the same as the others from gallery
  • The game has metadata at the top of the file in the following format:
    /*
    @title:
    @author:
    @description:
    @tags: []
    @addedOn: 2025-MM-DD
    */
    

Image (If an image is used)

Thanks for your PR!

@LucasHT22 LucasHT22 added the triaged This PR has been triaged - awaiting reviewer label Aug 30, 2025
@whatwareweb
Copy link
Collaborator

Your PR metadata looks good, a reviewer will look at it shortly

@whatwareweb whatwareweb added the awaiting-review Preliminary metadata check is complete, awaiting. review! label Sep 10, 2025
@whatwareweb whatwareweb self-assigned this Sep 16, 2025
Copy link
Collaborator

@whatwareweb whatwareweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

Just took a look at your game, and noticed a couple things:
First, there's some extra > characters before your metadata that are causing errors.
Second, it's not very clear how to play your game, could you add some instructions to the comment block at the top?

I corrected what you asked me to do.
@aloysboscariol
Copy link
Contributor Author

I just updated the game :) !

fixed something
@whatwareweb
Copy link
Collaborator

OK, just looked at your game again.

First off, the game mechanics seem really nice, the physics are super clean.

Some things to do to improve it before we merge:

  • I saw the instructions you put and then removed, could you just put those in a standard /* javascript comment block */ ?
  • Improving the artwork could really give this game a level of polish. Making a background as well as some sprites for the player and enemies would be awesome. If you really want to go above and beyond to give the game some polish you might even consider adding animations if you want to do something extra

Thanks for your PR, looking good so far!

I added a game menu, 3 skins variants and 3 maps.
@aloysboscariol
Copy link
Contributor Author

I just updated the game.
I added:

  • Game menu
  • 3 skins variants
  • 3 maps variants
  • input list down the screen
    But I couldn't add animations because the game was always crashing.
    I'll add:
  • More instructions in the game comment
  • A game thumbail (i'm working on it right now)

I just added my new thumbnail
Fixed the last bugs (map, wrong color skins)
@aloysboscariol
Copy link
Contributor Author

I added the instructions in the game comment, I added the thumbnail and I fixed the bugs. Let me know if there are any errors that I need to fix :)

@whatwareweb
Copy link
Collaborator

Hi, i saw the updates and that is looking good so far!

Only thing that needs to be done now before we merge is that sometimes when you shoot, it just goes right through the aliens without anything happening. Not sure what's causing that, but can you take a look? After that's fixed i'll merge

Thanks!

@aloysboscariol
Copy link
Contributor Author

aloysboscariol commented Sep 20, 2025

Thanks, I will look on my side to find the error!

@aloysboscariol
Copy link
Contributor Author

I think i see what's the problem.
In my code I do the collision test after an entry. But the aliens ' bullets move with "setInterval" so when a bullet touches an alien between 2 inputs, it doesn't work.

Changing afterInput to setInterval
@aloysboscariol
Copy link
Contributor Author

That's it! :)

@whatwareweb
Copy link
Collaborator

OK, this game looks good!

@whatwareweb whatwareweb dismissed their stale review September 23, 2025 15:44

game updated

@whatwareweb whatwareweb added this pull request to the merge queue Sep 23, 2025
Merged via the queue into hackclub:main with commit 9ad43ae Sep 23, 2025
@whatwareweb
Copy link
Collaborator

Thanks for your submission!

If you're a teen, you can get your Sprig here! sprig-order.hackclub.dev

Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Preliminary metadata check is complete, awaiting. review! triaged This PR has been triaged - awaiting reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants