-
Notifications
You must be signed in to change notification settings - Fork 1.5k
AlienBlast #3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlienBlast #3275
Conversation
Your PR metadata looks good, a reviewer will look at it shortly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Just took a look at your game, and noticed a couple things:
First, there's some extra > characters before your metadata that are causing errors.
Second, it's not very clear how to play your game, could you add some instructions to the comment block at the top?
I corrected what you asked me to do.
I just updated the game :) ! |
fixed something
OK, just looked at your game again. First off, the game mechanics seem really nice, the physics are super clean. Some things to do to improve it before we merge:
Thanks for your PR, looking good so far! |
I added a game menu, 3 skins variants and 3 maps.
I just updated the game.
|
I just added my new thumbnail
Fixed the last bugs (map, wrong color skins)
I added the instructions in the game comment, I added the thumbnail and I fixed the bugs. Let me know if there are any errors that I need to fix :) |
Hi, i saw the updates and that is looking good so far! Only thing that needs to be done now before we merge is that sometimes when you shoot, it just goes right through the aliens without anything happening. Not sure what's causing that, but can you take a look? After that's fixed i'll merge Thanks! |
Thanks, I will look on my side to find the error! |
I think i see what's the problem. |
Changing afterInput to setInterval
That's it! :) |
OK, this game looks good! |
Thanks for your submission! If you're a teen, you can get your Sprig here! sprig-order.hackclub.dev Hack Clubbers would love to see this! Just post a link and 1-2 sentences talking about your game to our #ship channel |
Your checklist for this pull request
Author name
Author:
Aloys
About your game
What is your game about?
Killing the aliens before they invade the earth
How do you play your game?
Menu Instructions:
Code
Check off the items that are true.
/games
directory.-
s, or_
s.Image (If an image is used)
/games/img
directory.