Skip to content

Conversation

@eunicode
Copy link
Member

@eunicode eunicode commented Nov 4, 2025

Fixes #1671

What changes did you make and why did you make them?

Refactored the Stats page (/admin) to replace JSX elements (e.g. <div>, <p>) with MUI layout and display components (<Box>, <Typography>, etc.) for improved code and design consistency and use of MUI’s built-in features.

Screenshots

No visual regressions were observed after the migration. The screenshots confirm that layout and appearance remain consistent.

Before (JSX elements) Before MUI migration
After (MUI components) After MUI migration

Discussion

Are there general guidelines on when to use Tailwind utility classes versus MUI’s sx prop or styled API?

Copy link
Member

@geolunalg geolunalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Minor nitpick — I would try to avoid cosmetic changes to the code so that only the necessary changes are visible in the PR. But like I said before, it looks good.

@JackHaeg JackHaeg added the ready for 2nd review When a PR is ready for another reviewer label Nov 11, 2025
},
},
signal
signal,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume most people are using vscode ... would implement a .prettierconfig to remove these kind of unwanted or sudden addition of commas an spaces in pull requests.

would help those who are reviewing the pull request, to review faster with less strain

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akibrhast I think there is already an implementation of some sort of linting. I would also be hesitant to assume anyone is using a particular IDE. I think this can be discussed during our team meeting.

Copy link
Member

@akibrhast akibrhast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for 2nd review When a PR is ready for another reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/admin/dashboard/index.jsx

4 participants