Update thermo.py #899
Open
Update thermo.py #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code only works on legacy materials API which .get_data method can be used. The new materials API using .summary.search method and returns objects. Now the code is modified to handle both the new and old materials project API. Depending on the API key length, the MPRester class in pymatgen will automatically chose the old or new API to query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The original code only works on legacy materials API which .get_data method can be used. The new materials API using .summary.search method and returns objects. Now the code is modified to handle both the new and old materials project API. Depending on the API key length, the MPRester class in pymatgen will automatically chose the old or new API to query.