Skip to content

Conversation

@E-Fir
Copy link

@E-Fir E-Fir commented Nov 8, 2022

Problem: initial validation messages don’t appear in some cases when any of Bootstrap frameworks are used.

How to reproduce:

  • open the Demonstration Playground
  • choose the "Bootstrap 3" or the "Bootstrap 4" framework
  • choose the "Angular Scheme Form/Bootstrap Grid" example
  • focus on the "Name" text input. Nothing is telling us that this field is required. Only if type something and remove all after that.
  • focus out of the "Name" text input when no validation error message is shown. The validation error message doesn't appear.
  • the same behavior with the "Email" field

Also, after I had wrote this I found a related issue: #315

Fix:

  • force validation on update value in the json-schema-form service
  • update value on focus in

E-Fir added 2 commits November 8, 2022 15:13
updateValue: mark as dirty before setting the value in order to run validation
Fixes hamzahamidi#315
@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for ajsf ready!

Name Link
🔨 Latest commit 6d347d2
🔍 Latest deploy log https://app.netlify.com/sites/ajsf/deploys/636a492a3487d100087b2ee4
😎 Deploy Preview https://deploy-preview-332--ajsf.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant